Repository navigation
Upgrade @bedrockio/logger to 2.0.0 - #327
Merged
Merged
Conversation
2.0.0 removes OpenTelemetry and tracing setup; logs are grouped by request via the traceparent / X-Cloud-Trace-Context headers instead. 2.0.0 was published inside the 7-day minimumReleaseAge window, so it is excluded by exact version in both pnpm workspaces.
API ChangesNo changes. |
andrewplummer
approved these changes
Oct 5, 2026
andrewplummer
left a comment
andrewplummer
left a comment
Collaborator
There was a problem hiding this comment.
approved but let's use the lock file instead
trustLockfile accepts the version already pinned in the committed lockfile, so the exclusions are not needed for installs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
@bedrockio/logger^1.1.3->^2.0.0inservices/apiandservices/web/serve.pnpm-workspace.yamlchanges. 2.0.0 was published 2026-10-05, inside the 7-dayminimumReleaseAgewindow;trustLockfile: trueaccepts it from the committed lockfile, so plainpnpm installworks as is.services/api/README.md: the Logging section no longer claims tracing, and the log-level example useslogger.warn(logger.warningdoes not exist in 2.0.0).Why
2.0.0 removes OpenTelemetry and all tracing setup (
useGoogleCloudTracing,setCloudConfig, thetracingoption onsetupGoogleCloud). Logs are grouped by request using thetraceparentorX-Cloud-Trace-Contextheaders. No code in this repo called the removed APIs, so there are no source changes.Reviewer notes
services/apistill installs logger 1.3.1 alongside 2.0.0:@bedrockio/model(^1.1.5) and@bedrockio/fixtures(^1.0.3) depend on 1.x, and their latest releases have not moved to 2.x. The OpenTelemetry packages therefore remain in the API lockfile until those are released upstream.services/web/servehas a single logger copy; its lockfile drops all OpenTelemetry packages (about 750 lines).pnpm update) needs--config.minimum-release-age=0.Verification
services/api:pnpm test399 passed (39 files),pnpm lintclean.services/web/serve: no test suite; verified the logger imports and logs under 2.0.0.